The effect of chromium (Cr) and iron (Fe) on prevalence of diabetes has received great attention. This study investigated serum and urinary Cr and Fe levels among patients with impaired fasting glucose (IFG), impaired glucose tolerance (IGT), type 1 diabetes (T1D), and type 2 diabetes (T2D) in the Northeast Chinese population. From January 2010 to October 2011, patients with IFG (n=12), IGT (n=15), T1D (n=25), T2D (n=137) and healthy controls (n=50) were enrolled in the First Hospital of Jilin University. Trace elements were detected using an inductively coupled plasma spectrometer. Serum Cr levels decreased in T2D without complications, diabetic retinopathy (DR), diabetic peripheral neuropathy (DPN), and diabetic nephropathy (DN) (P<0.05). The urinary Cr level in T1D was the highest of all, which significantly exceeded those of the T2D groups with and without complications. No significant differences of serum Fe levels were found among all groups. The urinary Fe level of T1D was significantly increased (P<0.05). The correlation between serum Cr and serum Fe in T2D was obviously positive (P<0.05). One month of simvastatin therapy exerted no effects on serum or urinary Cr and Fe levels. These results suggest the potential role of Cr and Fe in diabetes should receive attention.